Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final fixes from call with Karen #1150

Merged
merged 3 commits into from
Oct 31, 2024
Merged

final fixes from call with Karen #1150

merged 3 commits into from
Oct 31, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Oct 31, 2024

What does this change?

  • update all extend times to 5]reading time not doing time
  • also fix english test time to stated length
  • update sharelink instructions to wording agreed
  • fix erroneous 5 links claim

reading time not doing time

also fix english test time to stated length
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit 1b7f9c3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/67237655fddb000008cf08f6
😎 Deploy Preview https://deploy-preview-1150--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
@CodeYourFuture CodeYourFuture deleted a comment from netlify bot Oct 31, 2024
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I am not sure long-term about expressing open-ended stretch tasks as "5 minutes", but that's not a question for today.

@SallyMcGrath SallyMcGrath merged commit 7028d9f into main Oct 31, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the content/itd-2-fixes branch October 31, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants