Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regex to catch case #1166

Merged
merged 1 commit into from
Nov 1, 2024
Merged

add regex to catch case #1166

merged 1 commit into from
Nov 1, 2024

Conversation

SallyMcGrath
Copy link
Member

@SallyMcGrath SallyMcGrath commented Nov 1, 2024

What does this change?

This adds in a catch for the case where it's the root of the repo readme but /tree/main is on the path.

This is fine but the real question is why isn't the error caught in readme.html

Common Theme?

  • Yes read me paths

but the real question is why didn't it error
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6724d9954e86b40009733701

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6724d995f30e3300081716bc
😎 Deploy Preview https://deploy-preview-1166--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6724d995c3f86b000804700d

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6724d995f6aa740009f6e014
😎 Deploy Preview https://deploy-preview-1166--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6724d9954c713e000899789e
😎 Deploy Preview https://deploy-preview-1166--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6724d9957e38b70008931d0c
😎 Deploy Preview https://deploy-preview-1166--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6724d995651b450008b7eacb
😎 Deploy Preview https://deploy-preview-1166--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 018d623
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6724d99551942f0009576d32

@SallyMcGrath SallyMcGrath merged commit 13934ee into main Nov 1, 2024
34 checks passed
@SallyMcGrath SallyMcGrath deleted the bug/readme-case-miss branch November 1, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants