Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds workshop recommendations to module 3 #1196

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

fcaroline2020
Copy link
Contributor

What does this change?

Common Content?

  • Block/s

Common Theme?

  • Yes

Issue number: #issue-number

Org Content?

Module | Sprint | Page Type | Block Type

Checklist

Who needs to know about this?

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/6737923b8386a000089bb879
😎 Deploy Preview https://deploy-preview-1196--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6737923bf8e93600087244ac
😎 Deploy Preview https://deploy-preview-1196--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-common canceled.

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/6737923bd5a40d000867647e

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/6737923b1ef44f000840da85
😎 Deploy Preview https://deploy-preview-1196--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6737923b3e38eb0008b301d3

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/6737923b6b58d000082414b2
😎 Deploy Preview https://deploy-preview-1196--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/6737923bf7b09c000834a6ab
😎 Deploy Preview https://deploy-preview-1196--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for cyf-itd canceled.

Name Link
🔨 Latest commit 64b8456
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/6737923b10b28e0008728229

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the TBDs breaking the build :) Thanks!

I filed CodeYourFuture/CYF-Workshops#262 with a few minor copy edits to the workshops

@fcaroline2020 fcaroline2020 changed the title Adds technical workshop recommendations to module 3 Adds workshop recommendations to module 3 Nov 15, 2024
Copy link
Contributor

@kfklein15 kfklein15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fcaroline2020 fcaroline2020 merged commit 2000b54 into main Nov 15, 2024
34 checks passed
@fcaroline2020 fcaroline2020 deleted the workshop-recs-mod3 branch November 15, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants