Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the number of properties #1208

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

azaralampanah2
Copy link
Contributor

What does this change?

it amends the sentence that was written incorrectly.

it amends the sentence: "there are 3 properties" to "there are 4 properties" .
Path to the file: curriculum/common-content/en/module/js2/key-values/index.md

Common Content?

Yes

  • Block/s

Common Theme?

  • Yes

Issue number: #issue-number

Org Content?

Module | Sprint | Page Type | Block Type

Checklist

Who needs to know about this?

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit cb01f9d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/6740763b46780900085730be

Copy link

netlify bot commented Nov 22, 2024

👷 Deploy request for cyf-tracks pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb01f9d

Copy link

netlify bot commented Nov 22, 2024

👷 Deploy request for cyf-itd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb01f9d

Copy link

netlify bot commented Nov 22, 2024

👷 Deploy request for cyf-common pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb01f9d

Copy link

netlify bot commented Nov 22, 2024

👷 Deploy request for cyf-piscine pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb01f9d

Copy link

netlify bot commented Nov 22, 2024

👷 Deploy request for cyf-launch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb01f9d

Copy link

netlify bot commented Nov 22, 2024

👷 Deploy request for cyf-sdc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb01f9d

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit cb01f9d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/6740763bfa616b000840ad71
😎 Deploy Preview https://deploy-preview-1208--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks so much for fixing this!

One note about PRs in general - I see you made this change on the main branch of your fork:

Screenshot 2024-11-22 at 13 09 29

In general I'd recommend never committing any changes to a main branch - instead to make a new branch for the change you're making, and make the PR from that.

The main reason for this is that you generally want to keep main in sync with who you forked from. That's harder if you have your own local changes to it. The model we tend to use is: Make a branch, PR from the branch, merge to main on GitHub, pull in those changes to your local main.

@illicitonion illicitonion changed the title amending part of the sentence Fix typo in the number of properties Nov 22, 2024
@illicitonion illicitonion merged commit 224b1d1 into CodeYourFuture:main Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants