-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in the number of properties #1208
Conversation
✅ Deploy Preview for cyf-curriculum canceled.
|
👷 Deploy request for cyf-tracks pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-itd pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-common pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-piscine pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-launch pending review.Visit the deploys page to approve it
|
👷 Deploy request for cyf-sdc pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks so much for fixing this!
One note about PRs in general - I see you made this change on the main
branch of your fork:
In general I'd recommend never committing any changes to a main
branch - instead to make a new branch for the change you're making, and make the PR from that.
The main reason for this is that you generally want to keep main
in sync with who you forked from. That's harder if you have your own local changes to it. The model we tend to use is: Make a branch, PR from the branch, merge to main on GitHub, pull in those changes to your local main.
What does this change?
it amends the sentence that was written incorrectly.
it amends the sentence: "there are 3 properties" to "there are 4 properties" .
Path to the file: curriculum/common-content/en/module/js2/key-values/index.md
Common Content?
Yes
Common Theme?
Issue number: #issue-number
Org Content?
Module | Sprint | Page Type | Block Type
Checklist
Who needs to know about this?