-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strings.md added in the kotlin folder #1472
Conversation
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@Dusch4593 I have committed the changes from my end please check if there's any other changes required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dakshdeepHERE Thanks for the prompt turnaround on the feedback! 😄
I had some additional suggestions to make before we merge.
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@Dusch4593 the changes are done please check it. Sorry I was in college so I was not able to do the changes before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
Thanks @dakshdeepHERE! 😄
👋 @dakshdeepHERE |
@Dusch4593 Thanks a lot for the merge and the checks :D |
@dakshdeepHERE Thank you for contributing to Codecademy Docs! 🎊 🎉 🥳 The entry should now be live: https://www.codecademy.com/resources/docs/kotlin/strings Currently, your profile is anonymously listed on the entry page. To make it visible, you'll need to add your GitHub username to your Codecademy profile, log out of Codecademy, and log back in with your GitHub account: Looking forward to your next Docs contribution! 😄 |
@Dusch4593 I logged into my codecademy acc and linked my github and re logged in with github but its still showing anonymous |
Let's give it a little time; sometimes these kinds of updates will lag but will ultimately activate. |
@Dusch4593 oh alright ! Also I have other pr which are done with 2 reviews please check them too if you can. 😃 |
@dakshdeepHERE Hmmm are we certain that the GitHub username added was spelled correctly? I'm not seeing your GitHub handle under your Codecademy username: |
@Dusch4593 Is this right? or I have to put the whole link there of my github profile? |
@dakshdeepHERE Just "dakshdeepHERE" is fine. If you saved this change to your Codecademy profile, it may take time for that update to take effect. Will keep an eye on the Strings entry, though! And yes, I will work to get to your other PRs sometime today. 😄 |
@Dusch4593 oh alright ! Yep I have like 4 more pr waiting for you out there which are done with 2 reviews and 3 with 1 review done 😅 |
@dakshdeepHERE quick question: are you using the same email address for your Codecademy and GitHub accounts? |
@Dusch4593 yes I used the same email for my Codecademy and GitHub account. I also verified after by logging out and logging in later with my GitHub account. |
@Dusch4593 But when I was signing up I didn't manually put my email, name and all. I directly used the google sign up method on which this GitHub account is linked too. |
@Dusch4593 Its here ! |
Description
Type of Change
Checklist
main
branch.Fixes #1473