Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings.md added in the kotlin folder #1472

Merged
merged 70 commits into from
Jan 11, 2023
Merged

strings.md added in the kotlin folder #1472

merged 70 commits into from
Jan 11, 2023

Conversation

dakshdeepHERE
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE commented Jan 8, 2023

Description

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

Fixes #1473

dakshdeepHERE and others added 30 commits January 1, 2023 23:15
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: SSwiniarski <86081858+SSwiniarski@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
Co-authored-by: Christine Yang <72277593+yangc95@users.noreply.github.com>
dakshdeepHERE and others added 3 commits January 11, 2023 00:51
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 I have committed the changes from my end please check if there's any other changes required.

Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dakshdeepHERE Thanks for the prompt turnaround on the feedback! 😄

I had some additional suggestions to make before we merge.

content/kotlin/concepts/strings/strings.md Outdated Show resolved Hide resolved
content/kotlin/concepts/strings/strings.md Show resolved Hide resolved
content/kotlin/concepts/strings/strings.md Outdated Show resolved Hide resolved
content/kotlin/concepts/strings/strings.md Outdated Show resolved Hide resolved
content/kotlin/concepts/strings/strings.md Show resolved Hide resolved
content/kotlin/concepts/strings/strings.md Outdated Show resolved Hide resolved
dakshdeepHERE and others added 7 commits January 11, 2023 18:36
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
Co-authored-by: Brandon Dusch <brandondusch@gmail.com>
@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 the changes are done please check it. Sorry I was in college so I was not able to do the changes before.

Copy link
Contributor

@Dusch4593 Dusch4593 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

Thanks @dakshdeepHERE! 😄

@Dusch4593 Dusch4593 merged commit 80094ba into Codecademy:main Jan 11, 2023
@github-actions
Copy link

👋 @dakshdeepHERE
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 Thanks a lot for the merge and the checks :D

@Dusch4593
Copy link
Contributor

@dakshdeepHERE Thank you for contributing to Codecademy Docs! 🎊 🎉 🥳

The entry should now be live: https://www.codecademy.com/resources/docs/kotlin/strings

Currently, your profile is anonymously listed on the entry page. To make it visible, you'll need to add your GitHub username to your Codecademy profile, log out of Codecademy, and log back in with your GitHub account:

Screen Shot 2023-01-11 at 11 40 47 AM

Looking forward to your next Docs contribution! 😄

@dakshdeepHERE
Copy link
Collaborator Author

dakshdeepHERE commented Jan 11, 2023

@Dusch4593 I logged into my codecademy acc and linked my github and re logged in with github but its still showing anonymous
image
my profile link

@Dusch4593
Copy link
Contributor

@Dusch4593 I logged into my codecademy acc and linked my github and re logged in with github but its still showing anonymous

image

Let's give it a little time; sometimes these kinds of updates will lag but will ultimately activate.

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 oh alright ! Also I have other pr which are done with 2 reviews please check them too if you can. 😃

@Dusch4593
Copy link
Contributor

Dusch4593 commented Jan 11, 2023

@dakshdeepHERE Hmmm are we certain that the GitHub username added was spelled correctly? I'm not seeing your GitHub handle under your Codecademy username:

Screen Shot 2023-01-11 at 11 59 57 AM

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 Is this right? or I have to put the whole link there of my github profile?
image

@Dusch4593
Copy link
Contributor

Dusch4593 commented Jan 11, 2023

@dakshdeepHERE Just "dakshdeepHERE" is fine. If you saved this change to your Codecademy profile, it may take time for that update to take effect. Will keep an eye on the Strings entry, though!

And yes, I will work to get to your other PRs sometime today. 😄

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 oh alright ! Yep I have like 4 more pr waiting for you out there which are done with 2 reviews and 3 with 1 review done 😅

@Dusch4593
Copy link
Contributor

@dakshdeepHERE quick question: are you using the same email address for your Codecademy and GitHub accounts?

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 yes I used the same email for my Codecademy and GitHub account. I also verified after by logging out and logging in later with my GitHub account.

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 But when I was signing up I didn't manually put my email, name and all. I directly used the google sign up method on which this GitHub account is linked too.

@dakshdeepHERE
Copy link
Collaborator Author

@Dusch4593 Its here !
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concept Entry] Kotlin: Adding string.md in kotlin folder
3 participants