feat!: added Menu component family using Reach UI #1163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
force-pushed
the
jg-menu
branch
from
2d53cb8 to
52b66c3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 69.18% 69.36% +0.17%
==========================================
Files 283 289 +6
Lines 2233 2246 +13
Branches 784 786 +2
==========================================
+ Hits 1545 1558 +13
+ Misses 678 677 -1
- Partials 10 11 +1
|
4 tasks
JoshuaKGoldberg
force-pushed
the
jg-menu
branch
from
e2f6aba to
0ff04e9
Compare
JoshuaKGoldberg
commented
Nov 19, 2020
JoshuaKGoldberg
commented
Nov 19, 2020
sooinc
reviewed
Nov 23, 2020
| import { listItemStyles } from './styles'; | ||
|
|
||
| export const MenuLink = styled(ReachMenuLink)` | ||
| ${listItemStyles} |
There was a problem hiding this comment.
ooh didn't know we can style this way! thx for teaching me
jcenglish
reviewed
Nov 23, 2020
|
I think it'd be helpful for the submenus' |
JoshuaKGoldberg
commented
Nov 24, 2020
Comment on lines
16
to
18
| &[data-focus-visible-added] { | ||
| box-shadow: 0 0 0 2px ${colors.black}; | ||
| } |
There was a problem hiding this comment.
📬Published Alpha Packages:@codecademy/gamut-labs@5.7.3-alpha.0be953.0 |
|
🚀 Styleguide deploy preview ready! |
|
Closing to keep my PR queue small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR Checklist
Description
Directly uses a large portion of Reach UI's Menu Button family, with the addition of a
MenuButtonTogglefor the chevron icon expando logic.Slack thread on avoiding Popover directly
Renames the old
SideMenucomponent'sMenuItemtoSideMenuItemto distinguish it from theMenuItemhere.See also https://reach.tech/menu-button for now the menu button normally behaves. I was surprised that you can't use tabbing inside it when open, just up/down arrow keys...