Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Added ability isolate and verify mock objects within a specification" #35

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Revert "Added ability isolate and verify mock objects within a specification" #35

merged 1 commit into from
Oct 17, 2016

Conversation

sergeyklay
Copy link
Contributor

Reverts #34

@sergeyklay
Copy link
Contributor Author

sergeyklay commented Oct 17, 2016 •
edited
Loading

@ischenko
I roll back these changes because they are completely broke our tests.
For example see: https://travis-ci.org/phalcon/cphalcon/jobs/168296807

Please try to sort out and cover your changes by providing some tests

@sergeyklay sergeyklay mentioned this pull request Oct 17, 2016
Merged
@DavertMik DavertMik merged commit 5fb1d68 into master Oct 17, 2016
@sergeyklay sergeyklay deleted the revert-34-verify-mock-objects branch October 17, 2016 22:28
@ischenko
Copy link
Contributor

ischenko commented Oct 18, 2016 •
edited
Loading

@sergeyklay
I've managed to reproduce the issue. It occurs when the Specify trait is inherited from base class (see Reproduced issue: Property SpecifyTest::$beforeSpecify does not exist).

I will commit a fix tonight.

@ischenko
Copy link
Contributor

@sergeyklay
I've created a pull request with the fix ( see #37 ).

@ischenko ischenko mentioned this pull request Oct 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergeyklay @ischenko @DavertMik