Refactor count/notCount parameter name #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new name more accurately describes the datatype of the parameter and it is in line with the underlying PHPUnit method parameter name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current parameter name for these two methods is
$arraywith no type suggested in PHPDoc. This could mislead the API consumer that this method accepts a parameter of type array.Checking into the source code, we can see that this method in fact calls PHPUnit's
assertCount, which takes the expected count as it's first parameter. I think that$expectedCountwould be a more appropriate name for this parameter, and it's the same name as used in PHPUnit'sassertCountmethod, which makes sense.