Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate domain based on plugin #2470

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 13, 2024

Closes #.

Summary

  • Separated the translation domain for each sub-plugin and Otter Pro
  • When the sub-plugin is bundled with Otter, their domains are changed to otter-blocks for JS and PHP files. (Their JS files have a check to load the translation based on their location -- in Otter or as an individual plugin).
  • Set stable tags for plugins.

Important

Unlike the PHP files, the JS have their translation tied up with their index.js path. You have to set the domain based on the USED script location.

Screenshots


Test instructions

  • Check the text-domain in each build folder to be separated.
  • Check stable tags.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/pro-strings branch 7 times, most recently from 1b6f19c to ecaf7e3 Compare February 3, 2025 16:00
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review February 3, 2025 16:00
@pirate-bot
Copy link
Contributor

pirate-bot commented Feb 3, 2025

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.41 KB 271.37 KB -36 B (-0.01%)
Blocks 1.56 MB 1.56 MB 122 B (0.01%)
CSS 100.89 KB 100.84 KB -48 B (-0.05%)
Dashboard 204.59 KB 204.56 KB -33 B (-0.02%)
Onboarding 161.1 KB 161.05 KB -48 B (-0.03%)
Export Import 97.78 KB 97.73 KB -49 B (-0.05%)
Pro 423.65 KB 421.76 KB -1.89 KB (-0.45%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Feb 3, 2025

Plugin build for 3a71177 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Feb 3, 2025
@pirate-bot
Copy link
Contributor

pirate-bot commented Feb 3, 2025

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 273.95, firstPaint: 534.85, domContentLoaded: 1578.45, loaded: 1579.15, firstContentfulPaint: 3690.5, firstBlock: 8180.4, type: 14.19, minType: 12.29, maxType: 18.18, typeContainer: 9.41, minTypeContainer: 8.43, maxTypeContainer: 12.29, focus: 36.68, minFocus: 32.37, maxFocus: 41.22, inserterOpen: 24.32, minInserterOpen: 21.45, maxInserterOpen: 33.18, inserterSearch: 0.73, minInserterSearch: 0.61, maxInserterSearch: 0.84, inserterHover: 3.09, minInserterHover: 2.79, maxInserterHover: 3.76, listViewOpen: 145.13, minListViewOpen: 132.71, maxListViewOpen: 163.7

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/pro-strings branch 5 times, most recently from 625ac7b to 59a57d8 Compare February 4, 2025 10:08
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 702d7d7 into development Feb 5, 2025
9 of 11 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/pro-strings branch February 5, 2025 10:12
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants