-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: separate domain based on plugin #2470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HardeepAsrani
approved these changes
Dec 16, 2024
1b6f19c
to
ecaf7e3
Compare
Bundle Size Diff
|
Plugin build for 3a71177 is ready 🛎️!
|
ecaf7e3
to
ee38b50
Compare
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 273.95, firstPaint: 534.85, domContentLoaded: 1578.45, loaded: 1579.15, firstContentfulPaint: 3690.5, firstBlock: 8180.4, type: 14.19, minType: 12.29, maxType: 18.18, typeContainer: 9.41, minTypeContainer: 8.43, maxTypeContainer: 12.29, focus: 36.68, minFocus: 32.37, maxFocus: 41.22, inserterOpen: 24.32, minInserterOpen: 21.45, maxInserterOpen: 33.18, inserterSearch: 0.73, minInserterSearch: 0.61, maxInserterSearch: 0.84, inserterHover: 3.09, minInserterHover: 2.79, maxInserterHover: 3.76, listViewOpen: 145.13, minListViewOpen: 132.71, maxListViewOpen: 163.7 |
625ac7b
to
59a57d8
Compare
59a57d8
to
1e057f4
Compare
HardeepAsrani
approved these changes
Feb 5, 2025
🎉 This PR is included in version 3.0.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-incomplete
The Pull Request checklist is incomplete. (automatic label)
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #.
Summary
otter-blocks
for JS and PHP files. (Their JS files have a check to load the translation based on their location -- in Otter or as an individual plugin).Important
Unlike the PHP files, the JS have their translation tied up with their
index.js
path. You have to set the domain based on the USED script location.Screenshots
Test instructions
Checklist before the final review