fix: error from TPC inside FSE editor. #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@preda-bogdan it's working well 👍 |
HardeepAsrani
approved these changes
Apr 28, 2023
| @@ -60,6 +60,12 @@ public function register_block() { | |||
| return; | |||
| } | |||
|
|
|||
| // Don't load on site editor. Until FSE support in TPC is added. | |||
| // We can remove this check once Codeinwp/templates-patterns-collection/issues/248 is implemented. | |||
| if ( $screen->id === 'site-editor' ) { | |||
|
🎉 This PR is included in version 1.1.39 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a check for the
site-editorscreen and, did not load the TPC module as template save or import is not supported yet.Opened a new ticket #248 to add support for saving FSE templates.
Test instructions
Closes #246.