-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to input values for license and creator for every chart #794
Comments
@vytisbulkevicius As per the requirement, we have added 2 new fields (Creator and License) in chart settings. Now the warnings are disspeared. QA steps
We have a question for the following chats.
Is there any reason you haven't added the description field in settings for all the above charts? We will not able to add (Creator and License) fields for all the above charts because the description field is required to validate chart schema. To fix the above issue, we need to add a description field for all the charts. |
@girishkrishaweb if the description field is required to validate it, we can add it. |
Ok sure. Let me add it. @selul |
#### Fixes: - Fix compatibility with 3rd party plugins which use the same js library as Visualizer #801 - Fix fatal error when a new chart is created on PHP 8 #795 - Chart doesn't get refreshed automatically when the JSON endpoint is used as the data source #### Features: - Adds option to add schema.org Dataset for license and creator #794
##### [Version 3.5.1](v3.5.0...v3.5.1) (2021-05-25) - Fix compatibility with 3rd party plugins which use the same js library as Visualizer [#801](#801) - Fix fatal error when a new chart is created on PHP 8 [#795](#795) - Chart doesn't get refreshed automatically when the JSON endpoint is used as the data source #### Features: - Adds option to add schema.org Dataset for license and creator [#794](#794)
🎉 This issue has been resolved in version 3.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description:
Schema.org @dataset is added to the chart if the Title and description are filled: https://vertis.d.pr/qdMpO5
Schema on the page - https://vertis.d.pr/QZQp4r
This works fine, however, when checking on Google structure data testing tool, there are warnings about adding two optional/recommended properties (license and creator):
https://vertis.d.pr/vbFu9u
There are many optional properties - https://developers.google.com/search/docs/data-types/dataset#dataset
However, warnings are thrown only for license and creator.
This doesn't break schema but as these are only 2 properties throwing warnings maybe we can add fields to the plugin's UI and allow users to input values for these 2 properties?
Alternatives:
Or per chart -
For users that have many charts, this is not a very practical approach.
Ticket - https://secure.helpscout.net/conversation/1468413923/272924/
The text was updated successfully, but these errors were encountered: