Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We can change copy Short Code icon #945

Closed
harshitarora-in opened this issue Oct 9, 2022 · 3 comments · Fixed by #946 or #948
Closed

We can change copy Short Code icon #945

harshitarora-in opened this issue Oct 9, 2022 · 3 comments · Fixed by #946 or #948
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@harshitarora-in
Copy link
Contributor

Currently we are using scissor icon to copy chart short code, but we can replace it with a more familiar icon.

Reference:

Current icon:
Desktop - 3 (1)

Recommended icon:
Desktop - 2
@harshitarora-in harshitarora-in changed the title We can change the copy Short Code icon We can change copy Short Code icon Oct 9, 2022
@girishpanchal30
Copy link
Contributor

Hey @harshitarora-in
Could you please provide me new icon? I can not find the icon in the existing ui-icon image.
Ref: https://github.com/Codeinwp/visualizer/blob/master/images/ui-icons.png

Thanks

@harshitarora-in
Copy link
Contributor Author

@girishpanchal30 Here is the Dashicon link

@girishpanchal30 girishpanchal30 added the enhancement Request to improve or optimize an existing feature or functionality in the project label Oct 10, 2022
girishpanchal30 added a commit that referenced this issue Oct 10, 2022
@girishpanchal30
Change copy shortcode icon #945
e8e92a7
@girishpanchal30 girishpanchal30 mentioned this issue Oct 10, 2022
Merged
@girishpanchal30 girishpanchal30 linked a pull request Oct 10, 2022 that will close this issue
Change copy shortcode icon #946
Merged
@vytisbulkevicius vytisbulkevicius linked a pull request Oct 12, 2022 that will close this issue
Release #948
Merged
@vytisbulkevicius vytisbulkevicius mentioned this issue Oct 12, 2022
Merged
vytisbulkevicius added a commit that referenced this issue Oct 12, 2022
@vytisbulkevicius
release: fixes
2e5dd69 
- Updated dependencies
- Change copy shortcode icon to clone a chart We can change copy Short Code icon #945
- Fix temp file creation issue on instawp selecting the line chart is not working on instawp #940
- Fix control Type error
- Fixed simple editor scrolling issue
- Fix filter broken layout
- Fix chartJs javascript error when rendering multiple charts
pirate-bot pushed a commit that referenced this issue Oct 12, 2022
chore(release): 3.8.1
cce8585 
##### [Version 3.8.1](v3.8.0...v3.8.1) (2022-10-12)

- Change copy shortcode icon to clone a chart We can change copy Short Code icon [#945](#945)
- Fix temp file creation issue on instawp selecting the line chart is not working on instawp [#940](#940)
- Fix control Type error
- Fixed simple editor scrolling issue
- Fix filter broken layout
- Fix chartJs javascript error when rendering multiple charts
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change copy shortcode icon Codeinwp/visualizer
Release Codeinwp/visualizer
3 participants
@harshitarora-in @pirate-bot @girishpanchal30