Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pip3 instead of pip #246

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: use pip3 instead of pip #246

merged 1 commit into from
Aug 18, 2023

Conversation

JavierCane
Copy link
Member

  • We are actually checking if platform::command_exists pip3 (not platform::command_exists pip before executing pip::update_all
  • Inside the pip::update_all function we are already interacting with pip3 in order to list outdated dependencies and show information about them
  • It does not feel consistent to use pip while actually updating these dependencies
  • It even throws an error every time we execute the up dotly command if we have not installed a Python environment further more the one which comes with macOS by default

@rgomezcasas rgomezcasas merged commit 7047a80 into main Aug 18, 2023
4 checks passed
@rgomezcasas rgomezcasas deleted the fix-pip branch August 18, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants