-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ignoring file deletions #76
Conversation
5b02d25
to
e022e7b
Compare
cc: @OnkarRuikar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @johnlk, gooooooood work 🎉 🙌
-
I have taken the freedom to commit some
README.md
changes in the branch instead of making them as a PR comment suggestions because GitHub does not allow me to do so due to implying some non-modified lines 😬Feel free to discuss any concern regarding the changes 🙏😇
-
Regarding the inspiration on Implementation for ignore_deleted option #61, I completely understand that, given the modifications in the project since that PR it is easier to implement it in a new PR (my fault on not reviewing them on time). However, I would propose to add @rwyland
as the merge commit co-author in order to give him credit for the contribution 😊Taking a look to his contributions to other public repositories, it would be just by adding the following to the merge commit:
Co-authored-by: Rob W <rlw0788@gmail.com>
Tweak action.yml
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
Co-authored-by: Onkar Ruikar <87750369+OnkarRuikar@users.noreply.github.com>
044d140
to
bcadc34
Compare
…he most related arguments to make it easier to read Improve the existing contribution guide (#74) * Improve the existing contribution guide * reorder the contribution steps to push testing up Co-authored-by: Javier Ferrer González <javier.ferrer@codely.com> * tweak contribution process opener copy Co-authored-by: Javier Ferrer González <javier.ferrer@codely.com> --------- Co-authored-by: Javier Ferrer González <javier.ferrer@codely.com> Put back accidental deletion
bcadc34
to
a0cfd49
Compare
What type of PR is this? (check all applicable)
Description
This change supports ignoring files which are wholly deleted. This seems to be a common ask. The new config variable is called
ignore_file_deletions
and relies on the files API to determine the status of a file.This change was inspired by #61 , but with updated patterns and tests.
How to test
I added unit tests for the new code paths to ensure everything is behaving as expected.
Link to issues addressed