Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct index.js path #12

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: correct index.js path #12

merged 2 commits into from
Sep 6, 2024

Conversation

rgomezcasas
Copy link
Member

@rgomezcasas rgomezcasas commented Sep 6, 2024

Without this the imports are:
image

This is because the index.js root is inside dist/src and not inside dist as the package.json signals.

I did this as a minor change, but this breaks how it has to be imported, so maybe this bugfix is a major bump?

This is failing since the 1.0.6 release: https://www.npmjs.com/package/@codelytv/primitives-type/v/1.0.6?activeTab=code

@rgomezcasas rgomezcasas added the bug Something isn't working label Sep 6, 2024
@rgomezcasas rgomezcasas merged commit 0bece8e into main Sep 6, 2024
3 checks passed
@rgomezcasas rgomezcasas deleted the fix-import-path branch September 6, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant