-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cra 18 #19
Open
DawidZlobecki
wants to merge
26
commits into
master
Choose a base branch
from
feature/CRA-18
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/cra 18 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feature CRA/2 :navbar menu plus logo * feature/CRA-2:addupdate * fix: feature/CRA-2 some fixes and changes * fix: some fixes * fix: some fixes * fix: fixed bugs with stepbystepitem and some fixes * fix: fix * fix: fixed problem with displaying hamburger and menu * fix: logo.png was moved to assets * fix: set the navbar elements into links and downsized a logo * rename class * fix: fixed button - adds class on click * added sliding to navbar in mobile mode * WIP * feat: add styles for hamburger menu add background image change logo image add image for section in main * refactor: change module name * refactor: change module name * feat: add custom hook change styles for navbar change navbar and menu file add style for swiper * fix: change className for hamburger * fix: change eslint rule Co-authored-by: JustD1d1t <starzyk.dawid.0826@gmail.com> Co-authored-by: dawidzlobecki <dawidzlobecki2@gmail.com> Co-authored-by: MaciejP <m.ponicki1995@gmail.com> Co-authored-by: Maciej Ponicki <72940506+MaciekPon@users.noreply.github.com>
* feat: Services list * feat: add DividerSection * Refactor: minor changes * Refactor: minor changes * Refactor: minor changes * Refactor: minor changes * Refactor: minor changes
* Merge branch 'master' into feature/CRA-15 * feat: add Encourage sectionto main page add another dog image add Section component
* refactor: add entry point in utils * refactor(auth-context): move AuthContext from js to jsx * refactor: move opinions and steps to constants * refactor: move steplist to main components * refactor: minor changes * feature: styles for forms * refactor: add rwd styles * refactor: self closing tags, class style instead tag * refactor: move erro span to component * refactor: errorBox gets children props instead error, export/import
* Merge branch 'master' into feature/CRA-15 * feat: add Encourage sectionto main page add another dog image add Section component * fix: change file name * feat: add section to main page add styles for section.jsx * feat: add changes from code review change image name in assets * fix: change images names * fix: change image name in encourage section
ruljin
requested changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested
src/mock/auth.js
Outdated
name: "userName", | ||
description: | ||
"Lorem ipsum dolor sit amet consectetur adipisicing elit. Ratione, placeat?", | ||
announcement: [1, 2, 3, 8, 9], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
src/modules/announcements/components/Announcement/Announcement.module.scss
Outdated
Show resolved
Hide resolved
* feat: add SearchAnnouncements * Feat: Some changes * feat: Added rating stars and styles * feat: media styles * feat: add styles to not found announcements * fix: remove console.log * fix: some fixes
Feature/cra 22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single announcement