[#27] check #59
[#27] check #59
Conversation
| @@ -11,7 +11,7 @@ import { Queen } from './pieces/Queen'; | |||
| class Board { | |||
| public static BOARD_SIZE = 8; | |||
|
|
|||
| private state: Array<Array<Piece | null>>; | |||
| public state: Array<Array<Piece | null>>; | |||
There was a problem hiding this comment.
to jest chujowe, myślę co z tym zrobić
There was a problem hiding this comment.
ale widzę ten sam ruch w innym prze :P
There was a problem hiding this comment.
u mnie jest na public, bo sie bardzo przyadło :P
asiaziola
force-pushed
the
27-check
branch
3 times, most recently
from
4e17e14
to
cf2a49d
Compare
asiaziola
requested review from
CaptainObjective,
lilareliga,
Nebrakada,
kowalczp,
mfrydrychowicz and
Ryczko
| const isMovePossible = !this.isCheck(piece); | ||
|
|
||
| this.movePiece(potentialMove, square); | ||
| piece!.hasMoved = false; |
There was a problem hiding this comment.
to tylko działa, jeśli bierka się wcześniej nie ruszyła - trzeba by zapisywać jej poprzedni status do stałej
There was a problem hiding this comment.
hmm, ale ona zawsze będzie się ruszać, o tutaj:
this.movePiece(square, potentialMove);
src/services/game-logic/Board.ts
Outdated
| @@ -27,6 +27,14 @@ class Board { | |||
| return this.state[square.row][square.column]; | |||
| } | |||
|
|
|||
| public checkAllSquares = (f: any) => { | |||
There was a problem hiding this comment.
czym jet F? jednoliterowe zmienne to zuo. 'callback' brzmi lepiej, a jeszcze lepiej jak od razu wiadomo co ten callback ma robić :)
| }; | ||
|
|
||
| moveNotResultWithCheck(move: Square, piece: Piece | null, square: Square) { | ||
| const potentialMove: Square = { row: move.row, column: move.column }; |
There was a problem hiding this comment.
const potentialMove = new Square(move.row, move.column) ?
| return isMovePossible; | ||
| } | ||
|
|
||
| private isCheck(piece: Piece | null): Boolean { |
|
|
||
| private isCheck(piece: Piece | null): Boolean { | ||
| const color = piece?.color === Colors.BLACK ? Colors.WHITE : Colors.BLACK; | ||
| let currentPlayerKing: Square | undefined = this.getKingForCheck(piece)?.position; |
| .filter((move) => this.moveNotResultWithCheck(move, piece, square)); | ||
| }; | ||
|
|
||
| moveNotResultWithCheck(move: Square, piece: Piece | null, square: Square) { |
| getKingForCheck = (piece: Piece | null): King | null => { | ||
| let king = null; | ||
| this.board.checkAllSquares((square: Piece) => { | ||
| if (square && square?.color === piece?.color && square.name === PieceNames.KING) king = square; |
There was a problem hiding this comment.
rozdzielmy to na oddzielne linie i opakujmy w { }
| @@ -23,7 +23,11 @@ class King extends Piece { | |||
| row: this.position.row + row, | |||
There was a problem hiding this comment.
do wyrzucenia linia 20 const [row, column] = positions; nie jest to używane nigdzie
No description provided.