User Input needs to be normalized #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During training the input is in [0,...,1] but when creating the user input array the data was copied directly from the graphics element and not normalized
enginefeeder101
added a commit
to enginefeeder101/Toy-Neural-Network-JS
that referenced
this pull request
Feb 11, 2018
|
Oh my! I can't believe I missed this! I think I may actually redo the "coding challenge" again since this is such a major error (and there are other things that could be improved as well.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During training the input is in [0,...,1] but when creating the user input array the data was copied directly from the graphics element so in [0,...,255] and not normalized