Skip to content

Commit

Permalink
fix poor performance with firefox when using eval as devtool (fac…
Browse files Browse the repository at this point in the history
…ebook#924)

Enable sourcemaps in development
  • Loading branch information
ekaradon authored and randycoulman committed May 8, 2017
1 parent 67fe690 commit b1585ec
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions packages/react-scripts/config/webpack.config.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,9 @@ var env = getClientEnvironment(publicUrl);
// ZEAL: Converted to a function to allow injecting the publicPath.
module.exports = function(publicPath) {
return {
// This makes the bundle appear split into separate modules in the devtools.
// We don't use source maps here because they can be confusing:
// https://github.com/facebookincubator/create-react-app/issues/343#issuecomment-237241875
// You may want 'cheap-module-source-map' instead if you prefer source maps.
devtool: 'eval',
// You may want 'eval' instead if you prefer to see the compiled output in DevTools.
// See the discussion in https://github.com/facebookincubator/create-react-app/issues/343.
devtool: 'cheap-module-source-map',
// These are the "entry points" to our application.
// This means they will be the "root" imports that are included in JS bundle.
// The first two entry points enable "hot" CSS and auto-refreshes for JS.
Expand Down

0 comments on commit b1585ec

Please sign in to comment.