bitbucket server auto commands

[mrT23]

PR Type

Enhancement, Bug fix

---

Description

• Enhanced the BitbucketServerProvider class with new methods like publish_file_comments and get_pr_owner_id.
• Improved error handling in methods such as _parse_pr_url and _get_pr.
• Added command processing and sequential execution in bitbucket_server_webhook.py.
• Implemented support for connection test in webhook handling.
• Improved logging and error handling in webhook processing.

---

Changes walkthrough 📝

Relevant files

Enhancement

bitbucket_server_provider.py Enhance Bitbucket Server Provider with new methods and error handling pr_agent/git_providers/bitbucket_server_provider.py Added publish_file_comments method. Enhanced _parse_pr_url method with better error handling. Added get_pr_owner_id method. Improved error handling in _get_pr method. +38/-13  bitbucket_server_webhook.py Enhance Bitbucket Server Webhook handling with command processing pr_agent/servers/bitbucket_server_webhook.py Added new imports for ast, List, and RedirectResponse. Implemented command processing and sequential execution. Added support for connection test in webhook handling. Improved logging and error handling. +77/-6

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🏅 Score: 75

🧪 No relevant tests

🔒 No security concerns identified

🔀 Multiple PR themes Sub-PR theme: Enhance Bitbucket Server Provider with new methods and error handling Relevant files: pr_agent/git_providers/bitbucket_server_provider.py Sub-PR theme: Enhance Bitbucket Server Webhook handling with command processing Relevant files: pr_agent/servers/bitbucket_server_webhook.py

⚡ Key issues to review Error Handling The method _get_pr has added error handling that logs and rethrows the exception, which might be redundant as the calling function should handle it. Consider simplifying by removing the rethrow and just logging the error. Method Implementation The method publish_file_comments is added but only contains a pass statement, indicating it's not implemented. Ensure to complete the implementation or remove if not needed. Command Processing The method _process_command modifies global settings which could lead to unintended side effects. Consider isolating settings modification to prevent potential issues in concurrent environments.

[KennyDizi]

It's such great PR; I've been looking for it for a couple of weeks.

[mrT23]

It's such great PR; I've been looking for it for a couple of weeks.

it pains my eyes to see the word "great" in relation to "bitbucket"
😄

[KennyDizi]

It's such great PR; I've been looking for it for a couple of weeks.

it pains my eyes to see the word "great" in relation to "bitbucket" 😄

It's true because Bitbucket is behind compared to GitHub. A lot of EURO companies are using Bitbucket and this PR is very important.

[mrT23]

It's such great PR; I've been looking for it for a couple of weeks.

it pains my eyes to see the word "great" in relation to "bitbucket" 😄

It's true because Bitbucket is behind compared to GitHub. A lot of EURO companies are using Bitbucket and this PR is very important.

a company that uses Bitbucket is in a disadvantage compared to its competitors.

[mrT23]

/improve --config.model="claude-3-5-sonnet"

[qodo-merge-pro]

PR Code Suggestions ✨

Latest suggestions up to 652ced5

Category	Suggestion	Score
Possible issue	Implement or explicitly mark publish_file_comments as not implemented Implement the publish_file_comments method to avoid having an empty method which might lead to confusion or unexpected behavior in the future. If the method is intentionally left unimplemented, consider raising a NotImplementedError with a clear message explaining why it is not implemented. pr_agent/git_providers/bitbucket_server_provider.py [118-119] def publish_file_comments(self, file_comments: list) -> bool: - pass + raise NotImplementedError("Publishing file comments is not supported for Bitbucket Server.") Apply this suggestion Suggestion importance[1-10]: 9 Why: Raising a NotImplementedError provides clarity and prevents potential confusion or misuse of the method, improving code maintainability and readability.	9
	Review and validate the use of update_settings_from_args in _process_command Ensure that the update_settings_from_args function in _process_command is necessary and correctly implemented. If it modifies global settings or has side effects that could affect other parts of the application, consider isolating these changes or clearly documenting the intended effect. pr_agent/servers/bitbucket_server_webhook.py [122] +# Ensure update_settings_from_args is necessary and correctly used other_args = update_settings_from_args(args) new_command = ' '.join([command] + other_args) Apply this suggestion Suggestion importance[1-10]: 6 Why: While the suggestion to review and validate the use of update_settings_from_args is valid, it is more of a reminder than an actionable code change. It highlights a potential issue but does not provide a concrete improvement.	6
Enhancement	Improve error handling in publish_inline_comments Add error handling for the publish_inline_comments method to manage cases where neither 'position', 'start_line', nor 'line' keys are present in a comment. This will improve the robustness of the method and provide clearer logging in case of unexpected input. pr_agent/git_providers/bitbucket_server_provider.py [287-296] for comment in comments: if 'position' in comment: ... elif 'start_line' in comment: # multi-line comment ... elif 'line' in comment: # single-line comment ... else: - get_logger().error(f"Could not publish inline comment: {comment}") + get_logger().error(f"Could not publish inline comment due to missing required keys ('position', 'start_line', or 'line'): {comment}") Suggestion importance[1-10]: 8 Why: The improved error message provides more context, which can be helpful for debugging and understanding why a comment could not be published.	8
	Validate commands before execution in _run_commands_sequentially Validate the commands_to_run list before attempting to run them in _run_commands_sequentially to ensure that it contains valid commands. This validation could include checking for empty strings or commands that are not supported, which would prevent potential errors during command execution. pr_agent/servers/bitbucket_server_webhook.py [102-112] for command in commands: + if not command.strip(): + get_logger().error(f"Skipping empty or invalid command: '{command}'") + continue try: body = _process_command(command, url) ... except Exception as e: get_logger().error(f"Failed to handle command: {command} , error: {e}") Suggestion importance[1-10]: 7 Why: Adding validation for commands improves the robustness of the code by preventing the execution of invalid or empty commands, which can lead to errors.	7

---

Previous suggestions

Suggestions up to commit 652ced5

Category	Suggestion	Score
Possible bug	Correct the return value to accurately reflect the PR owner's ID Replace the direct return of self.workspace_slug with a more appropriate attribute for the PR owner ID, such as self.pr.author.id, assuming that self.pr is a structured object containing PR details including the author's ID. pr_agent/git_providers/bitbucket_server_provider.py [308] -return self.workspace_slug +return self.pr.author.id Suggestion importance[1-10]: 8 Why: This suggestion corrects the return value to accurately reflect the PR owner's ID, which is a significant improvement and likely addresses a bug.	8
Possible issue	Implement error handling and logic for publishing file comments Add error handling for the pass statement in the publish_file_comments method to ensure that it does not silently fail. Implement a proper method body that handles file comments appropriately. pr_agent/git_providers/bitbucket_server_provider.py [119] -pass +try: + # Implement file comment publishing logic here + pass +except Exception as e: + get_logger().error(f"Failed to publish file comments, error: {e}") + return False Suggestion importance[1-10]: 7 Why: Adding error handling and logic for publishing file comments improves robustness and maintainability, but the exact implementation details are left unspecified.	7
Enhancement	Add error handling to the redirect function to improve robustness Modify the redirect_to_webhook function to handle potential exceptions and log them, ensuring robustness in redirect handling. pr_agent/servers/bitbucket_server_webhook.py [45] -return RedirectResponse(url="/webhook") +try: + return RedirectResponse(url="/webhook") +except Exception as e: + get_logger().error(f"Failed to redirect to webhook: {e}") + return JSONResponse(status_code=500, content={"message": "Internal Server Error"}) Suggestion importance[1-10]: 6 Why: Adding error handling to the redirect function improves robustness, but the likelihood of failure in this simple redirect is low, making the improvement minor.	6
Maintainability	Remove redundant code block for handling single-line comments Remove the redundant elif 'line' in comment: block since it duplicates the functionality of the elif 'start_line' in comment: block, and Bitbucket does not support range comments as noted. pr_agent/git_providers/bitbucket_server_provider.py [293-294] -elif 'line' in comment: # single-line comment - self.publish_inline_comment(comment['body'], comment['line'], comment['path']) +# Removed redundant handling for 'line' in comment Suggestion importance[1-10]: 3 Why: The suggestion is correct in identifying redundancy, but removing the block could lead to loss of functionality for single-line comments, which might still be necessary.	3