Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenAI o1 model and snapshot version o1-2024-12-17 #1402

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Add support for OpenAI o1 model and snapshot version o1-2024-12-17 #1402

merged 4 commits into from
Dec 22, 2024

Conversation

KennyDizi
Copy link
Contributor

@KennyDizi KennyDizi commented Dec 19, 2024 •
edited
Loading

PR Type

Feature, Enhancement

PR Description

  • Added support for the OpenAI o1 model and its snapshot version o1-2024-12-17 with a token limit of 204,800.
  • Updated O1_MODEL_PREFIX to o1 to align with the new OpenAI o1 model series.
  • Adjusted handling of prompts for the o1 model series, combining system and user prompts due to model limitations.

@qodo-merge-pro-for-open-source Qodo Merge Pro for Open Source
Copy link
Contributor

qodo-merge-pro-for-open-source bot commented Dec 19, 2024 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit 23678c1)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Token Limit

Verify that the 204,800 token limit for the new o1 models is accurate according to OpenAI's specifications and that the system properly handles this limit

    'o1-2024-12-17': 204800,  # 200K, but may be limited by config.max_model_tokens
    'o1': 204800,  # 200K, but may be limited by config.max_model_tokens

@qodo-merge-pro-for-open-source Qodo Merge Pro for Open Source
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@KennyDizi KennyDizi changed the title Add support OpenAI model o1 snapshot version o1-2024-12-17 [WIP] Add support OpenAI model o1 snapshot version o1-2024-12-17 Dec 19, 2024
@KennyDizi
Copy link
Contributor Author

DO NOT MERGE

@Shion1305 Shion1305 mentioned this pull request Dec 20, 2024
Closed
@KennyDizi KennyDizi changed the title [WIP] Add support OpenAI model o1 snapshot version o1-2024-12-17 Add support OpenAI model o1 and snapshot version o1-2024-12-17 Dec 22, 2024
@KennyDizi
Copy link
Contributor Author

It has been updated and is ready for code review @mrT23

@KennyDizi KennyDizi changed the title Add support OpenAI model o1 and snapshot version o1-2024-12-17 Add support for OpenAI o1 model and snapshot version o1-2024-12-17 Dec 22, 2024
@KennyDizi
Copy link
Contributor Author

🐲 🥦 The PR description has been updated to align with the latest commit (23678c1).

@KennyDizi
Copy link
Contributor Author

/review

@qodo-merge-pro-for-open-source Qodo Merge Pro for Open Source
Copy link
Contributor

Persistent review updated to latest commit 23678c1

@mrT23 mrT23 merged commit 20c506d into Codium-ai:main Dec 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrT23 mrT23 mrT23 approved these changes

Assignees
No one assigned
Labels
Review effort [1-5]: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KennyDizi @mrT23