fix: updates from review #1130
fix: updates from review #1130
Conversation
- a new util function to register projection classes - do not modify the global awkward behavior - tests for geometric dimension errors
…coffea into use_scikithep_vector
| vector.LorentzVectorArray, | ||
| PtEtaPhiMCandidateArray, # noqa: F821 | ||
| ) | ||
| register_projection_classes( |
There was a problem hiding this comment.
Ok this is my misunderstanding, I hadn't realized each case is somewhat different so the function doesn't in the end save any code duplication. Though at least for many of these the first 3 arguments are the same
There was a problem hiding this comment.
I think in this case what you had before was more readable code, is it ok to revert? No need to make separate PR
There was a problem hiding this comment.
arg, sorry, I thought convo was done, my bad
There was a problem hiding this comment.
I'll have to create a separate "revert" PR to fix this. There are some changes in this PR that should go in, like the extra tests and not modifying the global awkward behavior.
There was a problem hiding this comment.
Feel free to revert the subset of changes directly on the other PR and push, or make a revert PR if you prefer
XRef #991
cc: @nsmith- @lgray