Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the new type signature for copy_behaviors #1136

Merged
merged 2 commits into from
Aug 3, 2024
Merged

fix: use the new type signature for copy_behaviors #1136

merged 2 commits into from
Aug 3, 2024

Conversation

Saransh-cpp
Copy link
Contributor

Wait for the new awkward release. See scikit-hep/awkward#3177.

@Saransh-cpp Saransh-cpp marked this pull request as draft July 22, 2024 10:08
@lgray
Copy link
Collaborator

lgray commented Jul 23, 2024

anything more we need for this?

@Saransh-cpp
Copy link
Contributor Author

Saransh-cpp commented Jul 23, 2024 •
edited
Loading

Just a new awkward release; the fix is currently present in main.

TODO:

  • bump awkward's minimum required version

@lgray lgray closed this Aug 3, 2024
@lgray lgray reopened this Aug 3, 2024
@lgray lgray marked this pull request as ready for review August 3, 2024 03:37
@lgray lgray merged commit 801b775 into CoffeaTeam:use_scikithep_vector Aug 3, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saransh-cpp @lgray