Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ldap filter was not configurable. I added support for it. It's very useful to be able to restrict who can connect. Default value allow all active users on the ldap server. Work for an AD LDAP server, may require a different configuration for others LDAP implementations.
In my case, I override
burpui_ldap_filter
by adding a required group membership in a group variable.Btw, I had to add
ldap3>=2.9.1
in requirements_dev.txt to be able to use ldap support.