Deprecation warning - alternative #3615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to now also print warnings for both but hides the known ones for non-debug. |
Jackenmen
requested changes
Feb 26, 2020
There was a problem hiding this comment.
Few things that should be changed if we choose to handle #3612 in this way.
Also, this seems to missing one of the warnings mentioned in #3529?
<frozen importlib._bootstrap>:219: DeprecationWarning: an integer is required (got type float). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python.
|
I have also updated #3529 to make it easier to track these changes. |
|
@jack1142 I can remove the error messages and put a clearer error message if you want to reduce the clutter. |
Jackenmen
added
Blocked
Category: Bot Core
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #3613
Hides the known ones for non-debug and shows all for debug.
I did line number variant but could also do regex but I think line number may be better in this case incase there is two errors with same error but different linenumber. This could also be checked easily if it's fixed by debug.