Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparations for d.py 1.4 (includes breaking changes related to mass mentions) #3845

Merged
merged 9 commits into from
Aug 10, 2020
Merged

Preparations for d.py 1.4 (includes breaking changes related to mass mentions) #3845

merged 9 commits into from
Aug 10, 2020

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented May 12, 2020 •
edited
Loading

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This PR contains changes needed due to d.py 1.4 release as well as this (breaking) change:

  1. By default, none of the .send() methods will mention roles or @​everyone/@​here.
    1.1. d.py 1.4 introduces allowed_mentions kwarg to .send() methods that can be used to make the message mention roles or @​everyone/@​here (NOTICE: this may still change before d.py 1.4 release)
    1.2. sanitize_roles kwarg mentioned in the previous breaking change notice from Flame will NOT be implemented.
    1.3. The default value of the filter kwarg in Context.send() will be changed to None which means that enabling @​everyone/@​here mentions will now require using the allowed_mentions kwarg instead.

Fixes #4069 (indirectly, through dependency update)

@Jackenmen Jackenmen added Type: Enhancement Something meant to enhance existing Red features. Breaking Change Will potentially break some cogs. Type: Dependency Update Adding/updating/removing some of Red’s dependencies. Work In Progress Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. labels May 12, 2020
@Jackenmen Jackenmen added this to the 3.4.0 milestone May 12, 2020
@Jackenmen Jackenmen added the Release Blocker This needs handling prior to the next non-hotfix release. label May 12, 2020
@Jackenmen Jackenmen marked this pull request as ready for review August 6, 2020 16:39
@Jackenmen
Copy link
Member Author

This is now ready for review.

@Jackenmen Jackenmen mentioned this pull request Aug 6, 2020
Merged
3 tasks
@PredaaA PredaaA mentioned this pull request Aug 6, 2020
Closed
@Drapersniper Drapersniper self-assigned this Aug 10, 2020
@PredaaA @Jackenmen
Bump RLL version (and remove websockets dep) (Cog-Creators#3846)
2dbce09 
Squashed commit of the following:

commit 2ad447b
Merge: eab3107 fc2277b
Author: PredaaA <46051820+PredaaA@users.noreply.github.com>
Date:   Thu Aug 6 21:29:27 2020 +0200

    Merge branch 'V3/develop' into patch-9

commit eab3107
Author: jack1142 <6032823+jack1142@users.noreply.github.com>
Date:   Sat Jul 18 21:06:13 2020 +0200

    Remove DeprecationWarning filter for `websockets`

commit 62b3f34
Merge: 77dd7d7 49b1945
Author: jack1142 <6032823+jack1142@users.noreply.github.com>
Date:   Wed Jul 8 03:23:48 2020 +0200

    Merge branch 'V3/develop' into patch-9

commit 77dd7d7
Author: PredaMart <predaamart@outlook.com>
Date:   Tue May 12 21:52:47 2020 +0200

    well nuke here too

commit d3bb745
Author: PredaaA <46051820+PredaaA@users.noreply.github.com>
Date:   Tue May 12 21:47:26 2020 +0200

    Update setup.cfg

commit 47280bb
Author: PredaaA <46051820+PredaaA@users.noreply.github.com>
Date:   Tue May 12 21:41:35 2020 +0200

    Bump RLL version
Drapersniper
Drapersniper approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@Drapersniper Drapersniper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jack1142 and @PredaaA

@Drapersniper Drapersniper added the QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). label Aug 10, 2020
@Drapersniper Drapersniper merged commit 05ef5fa into Cog-Creators:V3/develop Aug 10, 2020
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 10, 2020
@Jackenmen Jackenmen deleted the V3/dpy_1.4 branch August 10, 2020 20:28
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 12, 2020
@Jackenmen Jackenmen mentioned this pull request Nov 8, 2020
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drapersniper Drapersniper Drapersniper approved these changes

Assignees

@Drapersniper Drapersniper

Labels
Breaking Change Will potentially break some cogs. Category: Core - API - Commands Package This is related to the `redbot.core.commands` package or `redbot.core.checks` module. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Release Blocker This needs handling prior to the next non-hotfix release. Type: Dependency Update Adding/updating/removing some of Red’s dependencies. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Alias does not handle space-only alias gracefully
4 participants
@Jackenmen @Drapersniper @Cog-CreatorsBot @PredaaA