Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaderboard error in DMs for global banks #4569

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Fix leaderboard error in DMs for global banks #4569

merged 1 commit into from
Oct 31, 2020

Conversation

phenom4n4n
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes leaderboard erroring in dms

@phenom4n4n phenom4n4n changed the title fix error in dms [bank] fix leaderboard error in dms Oct 30, 2020
Jackenmen
Jackenmen approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Jackenmen Jackenmen changed the title [bank] fix leaderboard error in dms Fix leaderboard error in DMs for global banks Oct 31, 2020
@Jackenmen Jackenmen added Category: Cogs - Economy This is related to the Economy cog. Type: Fix labels Oct 31, 2020
@Jackenmen Jackenmen added this to the 3.4.3 milestone Oct 31, 2020
@Jackenmen Jackenmen self-assigned this Oct 31, 2020
@Jackenmen
Copy link
Member

Thanks for PRing!

@Jackenmen Jackenmen merged commit 08c29d7 into Cog-Creators:V3/develop Oct 31, 2020
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Oct 31, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.4, 3.4.3 Nov 9, 2020
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Nov 16, 2020
@TurnrDev
Copy link
Contributor

Ah, that was my fault. Sorry guys.

@Jackenmen
Copy link
Member

No worries, bugs are a normal thing in development :)

@phenom4n4n phenom4n4n deleted the leaderboard_embeds branch February 7, 2021 02:11
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackenmen Jackenmen Jackenmen approved these changes

Assignees

@Jackenmen Jackenmen

Labels
Category: Cogs - Economy This is related to the Economy cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@phenom4n4n @Jackenmen @TurnrDev @Cog-CreatorsBot