Propbank/Treebank Reader for Ontonotes 5 #569
Conversation
| adjustTree(child, offset); | ||
| } | ||
| } | ||
|
|
| int s1 = c1.getStartSpan(); | ||
| int s2 = c2.getStartSpan(); | ||
| c1.equals(c2); | ||
| logger.error(hits+") Got them : "+c1+"("+s1+") -- "+c2+"("+s2+")"); |
There was a problem hiding this comment.
@cowchipkid this is the place you nitced wehave lots of hash colisions? #562
There was a problem hiding this comment.
Yes. We will need to come back to this. I wonder though if these collisions are the result of my poorly constructed constituents (I use using similar labels for both constituents and relations). I will need to come back to this, I want to see how big a problem this is on a less complete view, just tokens.
There was a problem hiding this comment.
Do we want to address this issue before merging the pr?
There was a problem hiding this comment.
I hate to leave this. But it's been like this forever as far as I can see, and it might take a while to really figure it out, so I would rather not delay this PR. I have a rare opportunity to use this huge machine to do the param sweep, offer ends at the end of next week, so I need to get on it. I think I will create another branch to work on this issue along with another significant issue I want to fix.
| import edu.illinois.cs.cogcomp.core.datastructures.IntPair; | ||
|
|
||
| /** | ||
| * This class captures data about the linkages between this node |
There was a problem hiding this comment.
"linkages between this node"? Can you clarify this plz?
There was a problem hiding this comment.
The relationship between the verb and it's arguments... Not sure what vocabulary I should use for this...
|
|
||
| /** | ||
| * base class for all SRL node arguments. | ||
| * @author redman |
There was a problem hiding this comment.
Can you clarify the documentation for this too? Is it suppose to represent one single constituent?
There was a problem hiding this comment.
This class represents one entry in the propbank file. For a particular verb, it contains the relationships of other bits of the sentence to that verb.
|
Looks good to me. Merging. |
|
Merging. |
This is the first draft propbank reader for ontonotes 5.