adding transliteration models. #577

danyaljj · 2017-10-30T00:49:21Z

add models for transliteration + add it to the pipeline @mayhewsw
change viewname of relations to RELATIONS @Slash0BZ

danyaljj · 2017-10-30T00:51:20Z

pipeline/src/main/java/edu/illinois/cs/cogcomp/pipeline/main/PipelineFactory.java

@@ -375,7 +378,7 @@ public static BasicAnnotatorService buildPipeline(ResourceManager rm) throws IOE
        }
        if (rm.getBoolean(PipelineConfigurator.USE_RELATION)){
            RelationAnnotator relationAnnotator = new RelationAnnotator();
-            viewGenerators.put(ViewNames.MENTION, relationAnnotator);
+            viewGenerators.put(ViewNames.RELATION, relationAnnotator);


@Slash0BZ is this cool?

I think RelationAnnotator class should be changed too, since it only adds a ViewNames.MENTION now

I can do the changes. Let me know

danyaljj · 2017-10-30T18:50:07Z

relation-extraction/src/main/java/org/cogcomp/re/RelationAnnotator.java

@@ -163,7 +177,7 @@ public void addView(TextAnnotation record) throws AnnotatorException {
                }
            }
        }
-        record.addView(ViewNames.MENTION, mentionView);
+        record.addView(ViewNames.RELATION, mentionView);


@Slash0BZ how does it look now?

danyaljj · 2017-10-30T18:50:18Z

relation-extraction/src/main/java/org/cogcomp/re/RelationAnnotator.java

+                File modelDir = ds.getDirectory("org.cogcomp.re", "SEMEVAL", 1.1, false);
+                modelFile = modelDir.getPath() + File.separator + "SEMEVAL" + File.separator + "SEMEVAL.lc";
+                lexFile = modelDir.getPath() + File.separator + "SEMEVAL" + File.separator + "SEMEVAL.lex";
+            }


How about here?

@Slash0BZ this is ok? I think it's not working ....

Did you use the same classifiers or different classifiers?

My bad, I forgot it's a different classifier. The classifier for SemEval is semeval_relation_classifier. Also you don't need the constrainedClassifier anymore, just directly use semeval_relation_classifier and then load model and lexicon

mssammon

Minor changes/questions...

mssammon · 2017-10-30T19:00:15Z

core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/datastructures/ViewNames.java

@@ -31,6 +31,7 @@
    public static final String POS = "POS";

    public static final String MENTION = "MENTION";
+    public static final String RELATION = "RELATION";


Please add a corresponding switch case in the 'getViewType()' method (https://github.com/danyaljj/illinois-cogcomp-nlp-1/blob/60b45aadcd689fbe5fc6e0af66ca0aa585c0cff7/core-utilities/src/main/java/edu/illinois/cs/cogcomp/core/datastructures/ViewNames.java#L134)

mssammon · 2017-10-30T19:02:03Z

pipeline/src/main/java/edu/illinois/cs/cogcomp/pipeline/server/MainServer.java

@@ -175,7 +173,7 @@ public static void main(String[] args) {
    }

    private static String annotateText(AnnotatorService finalPipeline, String text, String views,
-            Logger logger) throws AnnotatorException {
+                                       Logger logger) throws AnnotatorException {


Just curious: why is Logger a method argument, not a static class member? (the latter is more standard in CCG code)

Don't remember it now, but it seems odd. Fixed it.

mssammon · 2017-10-30T19:08:40Z

...tion/src/test/java/edu/illinois/cs/cogcomp/transliteration/TransliterationAnnotatorTest.java

    }

-/*    @Test
+    @Test
    public void testCleanText() throws AnnotatorException {
        TextAnnotation ta = DummyTextAnnotationGenerator.generateAnnotatedTextAnnotation(false, 3);
        annotator.getView(ta);
        assertEquals(true, ta.hasView(ViewNames.TRANSLITERATION));


this is a bit minimal -- can you test that there is some expected transliteration of a word in 'ta'?

Slash0BZ · 2017-10-30T19:21:44Z

relation-extraction/src/main/java/org/cogcomp/re/RelationAnnotator.java

            throw new AnnotatorException("Missing required view SHALLOW_PARSE");
        }
-        mentionAnnotator.addView(record);
+        if (!record.hasView(ViewNames.MENTION)) {
+            // TODO: show error messages if the mentions are not typed.


What you can do here (outside this 'if' of course) is something like

else{ if (record.getView(ViewNames.MENTION).getConstituents().get(0).getAttribute("EntityType").equals("MENTION")){ //The model does not have type } }

Good point.

Slash0BZ · 2017-10-30T20:58:44Z

relation-extraction/src/main/java/org/cogcomp/re/RelationAnnotator.java

@@ -188,7 +169,7 @@ public void addView(TextAnnotation record) throws AnnotatorException {
                }
            }
        }
-        record.addView(ViewNames.RELATION + "_" + type, mentionView);
+        record.addView(ViewNames.RELATION, mentionView);


here mentionView was initialized with ViewNames.MENTION, and now you are adding it to ViewNames.RELATION

Ah I see. I think it won't make any big problems. Will remember it ...

danyaljj · 2017-10-30T22:17:25Z

Planning to merge on green!

adding transliteration models.

daa6675

danyaljj requested a review from mssammon October 30, 2017 00:50

change relation view name.

cfdd8d0

danyaljj commented Oct 30, 2017

View reviewed changes

adding option to the relation annotato to load the semeval models.

60b45aa

danyaljj commented Oct 30, 2017

View reviewed changes

mssammon requested changes Oct 30, 2017

View reviewed changes

Slash0BZ reviewed Oct 30, 2017

View reviewed changes

khashab2 added 5 commits October 30, 2017 15:28

minor fixes.

e21c715

error messages when there is no type.

523df06

minor changes to re annotator.

8bfdd73

revert back some changes to REAnnotator.

9d11be0

minor comment.

b295741

Slash0BZ reviewed Oct 30, 2017

View reviewed changes

khashab2 added 3 commits October 30, 2017 17:06

ignore external annotator tests.

5655388

fix a compile error.

c40c2d3

fixing header snippet.

a87f4dc

danyaljj merged commit 82d19f9 into CogComp:master Oct 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding transliteration models. #577

adding transliteration models. #577

danyaljj commented Oct 30, 2017 •

edited

Loading

danyaljj Oct 30, 2017

Slash0BZ Oct 30, 2017

Slash0BZ Oct 30, 2017

danyaljj Oct 30, 2017

danyaljj Oct 30, 2017

danyaljj Oct 30, 2017

danyaljj Oct 30, 2017

Slash0BZ Oct 30, 2017

mssammon left a comment

mssammon Oct 30, 2017

danyaljj Oct 30, 2017

mssammon Oct 30, 2017

danyaljj Oct 30, 2017

mssammon Oct 30, 2017

danyaljj Oct 30, 2017

Slash0BZ Oct 30, 2017

danyaljj Oct 30, 2017

danyaljj Oct 30, 2017

Slash0BZ Oct 30, 2017

danyaljj Oct 30, 2017

Slash0BZ Oct 30, 2017

danyaljj commented Oct 30, 2017

adding transliteration models. #577

adding transliteration models. #577

Conversation

danyaljj commented Oct 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mssammon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danyaljj commented Oct 30, 2017

danyaljj commented Oct 30, 2017 •

edited

Loading