-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a ACEReaderWithTrueCaseFixer class #581
Conversation
closes #580 |
I was thinking that it might be a good idea if we move |
Ah that way ACEReaderWithTrueCaseFixer will be a package in stanford_3.3.1 so it can't extend ACEReader anymore right? |
the new reader can be in the external/ package, I agree... maybe point to it in the corpusreader documentation, though. I don't see why the reader can't extend ACEReader; package name/path doesn't have to be identical. |
So rather than copus-readers being dependant on stanford, stanford would be dependant on stanford. |
Just making sure, are we moving it to This way, external/stanford_3.3.1 will depends on corpusreader and it's fine right? @danyaljj |
No. Inside |
I understand, but all files in |
Ah you can keep the package naming compatible with corpus reader (which is what you currently have). |
external/stanford_3.3.1/pom.xml
Outdated
<dependency> | ||
<groupId>edu.illinois.cs.cogcomp</groupId> | ||
<artifactId>illinois-corpusreaders</artifactId> | ||
<version>3.1.35</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.1.36
Minor comment on versioning: merge after fixing it (and CI turning green). |
update usages upon this new class
Also a bug fix that cases opposite direction relations in RelationAnnotator.
Also added two new testing functions in MD and RE.