Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nesim type #625

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Nesim type #625

merged 3 commits into from
Apr 18, 2018

Conversation

sanjayss34
Copy link

Allow user to provide types for one or both names in NESim.compare()

@danyaljj
Copy link
Member

Thanks @sanjayss34 !
Two minor comments:
Could you please update the readme as well? (i.e. examples where we use NESim and how to enter the new arguments, possibly with a few examples).

@mssammon mssammon self-assigned this Apr 9, 2018
Copy link
Contributor

@mssammon mssammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one minor request: please fix the indentation (if you look at the file on the github web site you will see that your changes don't line up). You should be able to fix this from the command line, in the module directory: mvn formatter:format

Copy link
Contributor

@mssammon mssammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danyaljj danyaljj merged commit 426027a into CogComp:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants