Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-8695uhe5n: Update docs dependency pins #491

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Sep 16, 2024

Docs build issue was one where a transitive dependency (thinc) was installed on a version that required numpy>=2 yet the rest of the installed dependencies require numpy<2.
This happens because while the install versions of dependenices are pinned in the docs/requirements.txt file (which is used first), they don't all fall in line with what the library itself supports now.

So this PR updates the versions of dependencies in the docs/requirements.txt file.

Hopefully this will allow the docs to build successfully again.

@tomolopolis
Copy link
Member

Task linked: CU-8695uhe5n Docs are failing again (x3?)

@mart-r
Copy link
Collaborator Author

mart-r commented Sep 16, 2024

Just verified that the build passed on readthedocs when this branch was targeted.
https://readthedocs.org/projects/medcat/builds/25641024/

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 56a2856 into master Sep 16, 2024
8 checks passed
mart-r added a commit to mart-r/MedCAT that referenced this pull request Oct 14, 2024
* CU-8695uhe5n: Update docs dependency pins

* CU-8695uhe5n: Fix typo in fsspec version pin
mart-r added a commit that referenced this pull request Oct 14, 2024
* CU-8695uhe5n: Update docs dependency pins

* CU-8695uhe5n: Fix typo in fsspec version pin
@mart-r mart-r deleted the CU-8695uhe5n-docs-failing branch November 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants