Implement mouse support (point & click) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently this is just an experiment, and the function only works with non-scrolling directories
Implements a new scrolling system for mouse-mode and properly calculates the hovered item when scrolling the list. This hover should work with custom font sizes, but currently the calculations are not adding up for the header, so that is hardcoded. See the next commit for keybinds.
CogentRedTester
added
enhancement
Also undo a buggy previous attempt to rectify this that caused infinite scrolling behaviour when moving the mouse above or below the viewable list.
We no-longer set the font sizes directly as we did back when this code was first written.
Takes the number of header newlines into account when calculating the header height. This is experimental and may change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements mouse support. This feature must be enabled with the
script-opt
mouse_mode=yesand requires mpv v0.33.I would like to resolve the following issues before merging this PR:
update_mouse_pos()function. I want the calculation to work with any header font size, but the maths isn't adding up for some reason.Any feedback on these issues is welcome.
Resolves #22