chore(core/sha1): removed SHA1 helper function #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is obsolete and the name causes problems when linking with OpenSSL statically.
|
I'll take a better look later, but is it used anywhere? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is obsolete and the name causes problems when linking with OpenSSL statically.
Notice
to test it before making changes to Concord.
What?
Removed the SHA1 helper function.
Why?
The naming of this function causes problems when linking statically with OpenSSL.
How?
Rather than renaming it, it can be deleted since it is obsolete and not used.
Testing?
The function is never used and does not change the resulting code.