-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks, datatype, logging facility, documentation, ... #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kefile-only inclusion instead
…os, convert types that should be u64bitmask
…t supposed to be in a JSON string
…64bitmask, replace enumerators with macros
…enum discord_voice_speaking_flags with u64bitmask
…s used for testing)
… use lock callback instead of global mutex, use stack counter instead of a global one
…with discord_set_prefix()
…hen its string symbol is provided
lcsmuller
added
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
u64bitmask
.config.json
file.Why?
int
- going well over some of Discord's bitwise values (such as Permissions)How?
rest.c
test withgreatest.h
tools.FIELD_BITMASK()
gencodecs macro.root
logging module that can have N sub-modules linked to it (each module responsible for logging something unique). Client logging couldn't be configured manually because each module had its own copies of configuration values, instead of those being shared among them - this is now fixed.