Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Disconnect client(s) from their on-going session if a
SIGINT
is received.Why?
online
status until it fails to receive a heartbeat payload.How?
A
ccord_has_sigint
global is set once a SIGINT is detected, which will be checked against by all running clients and they will be prompted to calldiscord_shutdown()
.Testing?
Removed now outdated
test/async.c
logic that had a custom SIGINT handler for gracefully disconnecting, with this PRCtrl
+C
for a clean disconnect still works just fine.Anything Else? (optional)
I haven't added any mutexes around the
ccord_has_sigint
global var, doing so is trivial but I couldn't think of a scenario where multipleSIGINT
may be triggered in parallel.