Update dependencies, Bug fixes, OS detection #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' leads to reading memory garbage
…ets payload by reusing jsmn_pair
…ens and jsmnf pairs)
…o() for dynamic realloc
Ratelimiting refactor
…sh.h * refactor(discord-adapter_refcount.c): organize reference counter by creating a struct discord_refcounter structure
…uct discord_event' to src file scope
Update dependencies
…lization support, use built-in variables where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
uthash.hwithchash.hand updatejsmn-findversion - See Update dependencies #623.1. Regression where
logconf.clogging modules couldn't be disabled, therefore makingconfig.jsondisable_modulesfield useless.3.2. Uninitialized fields at
application_command.c- See a2d89b23.3. Timer passing ID 0 - See Timer Get Function Fix #64
Why?
"POSIX"is a simplification that may end-up becoming a inaccuracy as we support more systems in the future.3.1. Users reportedly were unable to use
discord_config_init()on some builds (Android) due to alogconf.cregression where astruct logconfmodule and its sub-modules would each attempt to handle theirlog_Logger *uniquely, when in reality the samelog_Logger*is shared amongst them all.3.2. Would lead to a segfault at best, or access memory garbage at worst.
3.3. See Timer Get Function Fix #64 for description
How?
osname.h, relying on the pre-processor to detect and assign the OS to aOSNAMEmacro.3.1. Add a
is_disabledboolean field tostruct logconf, if enabled for a particular module then it shall be ignored for outputting.3.2. Initialize
struct discord_requestnecessary for handling the preliminary Client to Discord request context3.3. See Timer Get Function Fix #64 for description
Testing?
http.logfor Discord Gateway's IDENTIFY payload.3.1. Test
discord_config_init()under valgrind for OOB detection.3.2. Test under valgrind for OOB detection.