Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): upgrade less-critical NPM modules #116

Merged
merged 1 commit into from
Jan 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ config/*
# END_CONFIT_GENERATED_CONTENT

# ignore the test fixtures which are designed to trigger errors
test/protractorSpec/*
test/spec/integration/fixtures/*
lib/buildTool/**/templates/**/*
lib/generators/**/templates/**/*
Expand Down
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ Files that you will need to look at:
- lib/generators/sampleApp
- lib/resources.yml
- lib/buildTool/\<tool (Webpack at this point in time)>/sampleApp
- test/protractorSpec

### I want to change the generated `README.md` file

Expand Down
11 changes: 10 additions & 1 deletion config/check-update/checkForUpdates.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,21 @@ function main() {
let packageData = {};

// Get list of packages
packageFile.$packages.forEach(pkg => packageData[pkg.name] = pkg.version);
packageFile.$packages.filter(onlyNpmPackages).forEach(pkg => packageData[pkg.name] = pkg.version);

// Pass list to ncu & display results
checkForUpdates(packageData);//{'swanky': '1.0.0', 'webpack': '1.0.0'});
}


function onlyNpmPackages(pkg) {
let isScopedPackage = pkg.name.indexOf('@') === 0;
let pkgIndexOfSlash = pkg.name.indexOf('/');

return isScopedPackage || pkgIndexOfSlash === -1;
}


function checkForUpdates(packageObj) {

ncu.run({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ var config = {
}));
},
function consoleReporter() {
var SpecReporter = require('jasmine-spec-reporter');
var SpecReporter = require('jasmine-spec-reporter').SpecReporter;
jasmine.getEnv().addReporter(new SpecReporter({
displayStacktrace: 'summary',
displaySpecDuration: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ <h1>This is page 1</h1>

<img src="../assets/img/logo.png">

<a class="btn" href="#/page2">Page 2</a>
<a class="btn" href="#!/page2">Page 2</a>
</div>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="page2">
<h2>This is page 2</h2>
<a href="#/page1" class="btn icon icon-menu-expand">Page 1</a>
<a href="#!/page1" class="btn icon icon-menu-expand">Page 1</a>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ <h1>This is page 1</h1>

<img src="../assets/img/logo.png">

<a class="btn" href="#/page2">Page 2</a>
<a class="btn" href="#!/page2">Page 2</a>
</div>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="page2">
<h2>This is page 2</h2>
<a href="#/page1" class="btn icon icon-menu-expand">Page 1</a>
<a href="#!/page1" class="btn icon icon-menu-expand">Page 1</a>
</div>
Loading