Add kem-API tests and move non kem-API interface related tests out of kem module #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
changed the title
This was referenced Jan 25, 2023
Merged
|
Hi @faern thank you for the clarification and adding these unit tests + refactor. I read your response at #34 & I agree that |
Colfenor
requested changes
Jan 25, 2023
Colfenor
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests not related to the
kemfeature were still placed in thekem_apimodule. Meaning they would only run if thekemfeature was active (which it is not in the CI). So I moved them out to the regular test module and made sure they work. For the tests running on the stack we must run it in a separate thread until we get the stack usage under control.I also added a test that verifies that the
CryptoCiphertextBytesTypenumalways corresponds toCRYPTO_CIPHERTEXTBYTESsince the CI passed when this was set wrong over in #33. This should help catch such errors.