Remove economy system from CPlot #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am still debating whether the EconomyManager and the provider classes (Base, BedrockEconomy, Capital) should still remain in this plugin or better moved to CPlotEconomyAddon as well. |
ColinHDev
added
Category: Core
|
I'm not comfortable with moving more and more features out of this plugin. |
ColinHDev
added
Status: Declined
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current economy system is very limited: It only allows server operators to set a fixed tax for claiming, clearing, resetting and merging plots. Although this might be enough for some people, it has definitive more potential, like a plot auctioning system, which got already discussed here with @jasonwynn10.
But adding more and more features to the economy part of this plugin would only increase the plugin's size while being completely useless for people who do not even use those features.
(Maybe some users of this plugin could comment on this pr and state if they use the economy feature overall, either with BedrockEconomy, Capital or a custom economy provider.)
Therefore this pull request aims to remove the economy part of the core plugin. Things that get removed in this pr will be added to the CPlotEconomyAddon, which will receive updates regarding economy features onwards.