-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api: ✏️ 사용자 아이디, 전화번호 수정 API 분리 #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn6878
approved these changes
Jul 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API분리작업 확인했습니다. 고생하셨습니다 👍
만약 사용자가 기존에 사용 중인 전화번호, 혹은 아이디를 수정 데이터로 보낸 경우 200 OK를 보내는 게 나을까요?
저는 클라이언트단에서 검증해 API호출을 막는다면, 저는 서버단에서 200과 409를 분리해줘야 할 이유는 없다는 생각입니다!
그럼 일단 막는 것으로 진행하도록 하겠습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
작업 사항
PATCH /v2/users/me/profile
→PATCH /v2/users/me/username
,PATCH /v2/users/me/phone
으로 수정리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈
name
과username
유효성 검사가 잘못되어 수정했습니다. 따로 PR을 분리하려고 했는데, username 수정이 이번 PR에 포함되어야 해서 함께 수정했습니다. (미리 이야기하고 진행했어야 했는데, 뒤늦게 깨달았습니다. 죄송합니다 ㅜㅜ)