Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Drupal permission system instead of the roles config #27

Closed
donquixote opened this issue Sep 9, 2024 · 2 comments · Fixed by #29
Closed

Use Drupal permission system instead of the roles config #27

donquixote opened this issue Sep 9, 2024 · 2 comments · Fixed by #29
Milestone
0.9.0-beta5

Comments

@donquixote
Copy link
Collaborator

(pull request soon...)
@hfiguiere hfiguiere added this to the 0.9.0-beta5 milestone Sep 9, 2024
@donquixote
Copy link
Collaborator Author

@hfiguiere Hi
Could you describe the significance of the IsAnonymousUser value sent with the WOPI response?

Currently in this Drupal module, the WOPI controller will return IsAnonymousUser = TRUE if and only if the user is anonymous in Drupal.

What would be the effect of returning the "wrong" value here?

@hfiguiere
Copy link
Collaborator

Currently it doesn't seem to be used, but there are plans to use it for things like comments. I think it should be carefully set for cases where the user isn't authenticated.

donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Clean up imports in all classes.
4ff4db8
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Replace the 'is_anonymous' pseudo-permission.
0eee773
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Replace usage of pseudo-permissions with Dr…
e996b4d 
…upal permissions.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Remove roles configuration.
8302c4e
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Remove the 'User permissions' section from …
aac8560 
…README.md, for now.

A new version of this section may be re-added later.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Simplify a condition in wopiCheckFileInfo().
8178595
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Require PHP >= 8.1 to allow for 'readonly'.
a703e0d
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Use constructor property promotion and read…
4ab9dac 
…only in ViewerController.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Rely on AutowireTrait in ViewerController.
a259820
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Split access checking into a service.
27e8137
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Let the access checker return an AccessResu…
c63ee3c 
…lt object.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Pass the media entity to the access checker…
b9a7720 
… service.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Declare dynamic permissions per media bundl…
764e751 
…e, replacing the global ones.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Replace global perms with per-bundle perms …
6a17b15 
…and 'edit own'.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Add a config schema.
7175e68
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Default to current user in CollaboraAccessC…
84b01de 
…heck.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Use the media entity from the field items i…
7a3d297 
…n the field formatter.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Rename $element -> $elements in the field f…
93d12ed 
…ormatter.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Check Collabora access in the field formatter.
2ff8140
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Require Collabora access for entity operati…
fb35751 
…on links, in addition to media access.

In this commit, no existing constraints are removed.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Clarify parentheses.
10a9c62 
This actually fixes a bug or misbehavior.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Use curl instead of file_get_contents() to …
602a659 
…get discovery.

It can happen that file_get_contents() hangs at the end of a stream, waiting for more data.
With curl it seems this does not happen.

Even better would be to use e.g. Guzzle http client, but that's too big a change for now.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Move controller access checks to the route …
c8754f1 
…definition for view and edit routes.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Separate access methods for preview and edit.
bcc2a26
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Test access to routes.
e0a249c
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Rely fully on entity access with custom ope…
e87eb69 
…rations.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Sep 13, 2024
@donquixote
Issue CollaboraOnline#27: Add some @todo for possibly empty variables.
dc42d13
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 23, 2024
@donquixote
Issue CollaboraOnline#27: Re-add a README section about permissions.
ad12a52
@donquixote donquixote mentioned this issue Oct 24, 2024
Merged
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 24, 2024
@donquixote
Merge pull request #1 from donquixote/issue-27-fix-permissions
3b6bf3d 
Issue CollaboraOnline#27: Use Drupal permission system.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Clean up and reorder imports.
7ceeb92 
This removes noise from following commits.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Replace the 'is_anonymous' pseudo-permission.
511ff42
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Replace usage of pseudo-permissions with Drupal permissions.
ae14be7 
Also remove roles configuration which is no longer needed now.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Remove the 'User permissions' section from README.md, for …
6a547a4 
…now.

A new version of this section may be re-added later.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Simplify a condition in wopiCheckFileInfo().
9688d27
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Require PHP >= 8.1 to allow for 'readonly'.
67882f6
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Add a config schema.
b95465c
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Replace access checks with entity access operation.
911beab
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Use the media entity from the field items in the field for…
4f018c2 
…matter.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Rename $element -> $elements in the field formatter.
c5362c3
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Check Collabora access in the field formatter.
1b5536a
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Check the new operations for entity operation links, inste…
2c2f030 
…ad of regular media access.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Move controller access checks to the route definition for …
4ef31f8 
…view and edit routes.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Replace global permissions with per-bundle perms and 'edit…
8a1d00b 
… own'.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Test access to routes.
6c42a57
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Add some @todo for possibly empty variables.
5688853
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Put a doc comment on WopiController::permissionDenied(), d…
71b5533 
…rop the `@todo` in the controller method.
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@AaronGilMartinez @hfiguiere
Issue #27: Remove uneeded classes and module in tests.
3687cfb
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@AaronGilMartinez @hfiguiere
Issue #27: Add license.
f93759d
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Add 'allowfullscreen' to config schema.
f918f68
hfiguiere pushed a commit that referenced this issue Oct 24, 2024
@donquixote @hfiguiere
Issue #27: Re-add a README section about permissions.
df48044
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 29, 2024
@donquixote
Issue CollaboraOnline#27: Use curl instead of file_get_contents() to …
980b465 
…get discovery.

It can happen that file_get_contents() hangs at the end of a stream, waiting for more data.
With curl it seems this does not happen.

Even better would be to use e.g. Guzzle http client, but that's too big a change for now.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 29, 2024
@donquixote
Issue CollaboraOnline#27: Use curl instead of file_get_contents() to …
7955c79 
…get discovery.

It can happen that file_get_contents() hangs at the end of a stream, waiting for more data.
With curl it seems this does not happen.

Even better would be to use e.g. Guzzle http client, but that's too big a change for now.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 29, 2024
@donquixote
Issue CollaboraOnline#27: Use curl instead of file_get_contents() to …
4bbceab 
…get discovery.

It can happen that file_get_contents() hangs at the end of a stream, waiting for more data.
With curl it seems this does not happen.

Even better would be to use e.g. Guzzle http client, but that's too big a change for now.
donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 29, 2024
@donquixote
Issue CollaboraOnline#27: Use curl instead of file_get_contents() to …
383e884 
…get discovery.

It can happen that file_get_contents() hangs at the end of a stream, waiting for more data.
With curl it seems this does not happen.

Even better would be to use e.g. Guzzle http client, but that's too big a change for now.
@donquixote donquixote mentioned this issue Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0-beta5
Development

Successfully merging a pull request may close this issue.

Issue #27: Use Drupal permission system donquixote/collabora-drupal
2 participants
@hfiguiere @donquixote