Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning if 'allowfullscreen' config option has not been saved yet. #41

Closed
donquixote opened this issue Oct 22, 2024 · 1 comment · Fixed by #42
Closed

Warning if 'allowfullscreen' config option has not been saved yet. #41

donquixote opened this issue Oct 22, 2024 · 1 comment · Fixed by #42
Milestone

Comments

@donquixote
Copy link
Collaborator

In some places we query the new 'allowfullscreen' config option.
This causes a warning, if the new settings have not been saved yet.

Warning: Undefined array key "allowfullscreen"

donquixote added a commit to donquixote/collabora-drupal that referenced this issue Oct 22, 2024
@donquixote
Copy link
Collaborator Author

Note: This is mostly relevant for new settings, which have been introduced after the module was first installed on a website.

There are different ways to deal with this.
E.g. we could populate the setting with an update hook, but I would prefer to go for a simpler option, which can be improved later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants