Add a note that the calculation for the ServerNamesHashMaxSize seems …

…to be wrong See also kubernetes#564
Collaborne · Apr 6, 2017 · a5287f8 · a5287f8
1 parent 7ca7652
commit a5287f8
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/controllers/nginx/pkg/cmd/controller/nginx.go b/controllers/nginx/pkg/cmd/controller/nginx.go
@@ -329,6 +329,8 @@ func (n *NGINXController) OnUpdate(ingressCfg ingress.Configuration) ([]byte, er
 	var longestName int
 	var serverNames int
 	for _, srv := range ingressCfg.Servers {
+		// XXX: serverNames should actually be based on the _number_ of server names, not the total size.
+		//      See http://nginx.org/en/docs/http/server_names.html
 		serverNames += len([]byte(srv.Hostname))
 		if longestName < len(srv.Hostname) {
 			longestName = len(srv.Hostname)