Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.js crashes browser on boxed layout when resizing window #683

Closed
kspearrin opened this issue Sep 14, 2015 · 18 comments
Closed

app.js crashes browser on boxed layout when resizing window #683

kspearrin opened this issue Sep 14, 2015 · 18 comments

Comments

@kspearrin
Copy link

See example here: http://s.codepen.io/kspearrin/debug/WQrERZ?

Using Firefox or Chrome, make your browser not full screen, then grab your window at the bottom right corner and drag it around a lot to make different sizes. The app.js script crashes the browser as it redraws the page.

Maybe related: #502

@almasaeed2010
Copy link
Contributor

Hello @kspearrin

This issue only occurs with the boxed layout which is a bit odd. I'll look further into it. Thanks for letting me know.

The issue is replicable in this demo page

@gusta21
Copy link

gusta21 commented Oct 7, 2015

@kspearrin i had the same behaviour, and i don´t remember how i fixed, I think i only replace the layout-boxed in the js and put something else (layout-box, for example). Its working well.

@lanaguanifw
Copy link

layout-boxed is unusable due to this bug.

@iyurtsever
Copy link

Hello,
I am facing same issue. When do you think to fix it?

@lanaguanifw
Copy link

I have solved this way:
master...lanaguanifw:patch-1

But even untested, not if have other implications.

What is certain is that the error occurs because the calls _this._fix(sidebar) accumulate.

@iyurtsever
Copy link

@lanaguanifw ,
thanks for your help. I changed the js file and test it but unfortunately still it is crashing :(

@lanaguanifw
Copy link

I just found another solution of another user:
https://github.com/almasaeed2010/AdminLTE/pull/799/files

@iyurtsever
Copy link

@lanaguanifw
I tried this solution as well, with no luck :(
some piece of code makes CPU top. Then screen becomes unresponsive :(

@by12
Copy link

by12 commented Apr 29, 2016

@lanaguanifw try by adding the following code in activate function in js file. for example just paste it after line 464.

if ($("body").hasClass('layout-boxed')) {
$(window).resize(function () {
_this._fix(sidebar);
});
}

@kspearrin
Copy link
Author

kspearrin commented Jun 10, 2016

@almasaeed2010 Any update on looking into this? This fix seems to solve the issue: https://github.com/almasaeed2010/AdminLTE/pull/799/files

@kspearrin
Copy link
Author

There a reason why this was closed? Still an issue...

@almasaeed2010
Copy link
Contributor

Please see #1086

@almasaeed2010
Copy link
Contributor

A temporary solution has been added based on @lanaguanifw's suggestion. It is imperfect in that when the page expands the height of the page will not get fixed. But this issue is lesser of the two evils. We will keep working on finding a solution to solve this problem permanently. Meanwhile, this should suffice.

@kspearrin
Copy link
Author

What was wrong with this suggestion? https://github.com/almasaeed2010/AdminLTE/pull/799/files

This seems to work with window height adjustments after page load.

@almasaeed2010
Copy link
Contributor

I tried the solution before but it didn't work. Have you tried it?

@kspearrin
Copy link
Author

Yes, it worked fine for me.

@almasaeed2010
Copy link
Contributor

Let me attempt one more time

almasaeed2010 added a commit that referenced this issue Jul 1, 2016
@almasaeed2010
Copy link
Contributor

Fixed permanently.

Thanks @kspearrin and everyone for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants