-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app.js crashes browser on boxed layout when resizing window #683
Comments
Hello @kspearrin This issue only occurs with the boxed layout which is a bit odd. I'll look further into it. Thanks for letting me know. The issue is replicable in this demo page |
@kspearrin i had the same behaviour, and i don´t remember how i fixed, I think i only replace the layout-boxed in the js and put something else (layout-box, for example). Its working well. |
layout-boxed is unusable due to this bug. |
Hello, |
I have solved this way: But even untested, not if have other implications. What is certain is that the error occurs because the calls |
@lanaguanifw , |
I just found another solution of another user: |
@lanaguanifw |
@lanaguanifw try by adding the following code in activate function in js file. for example just paste it after line 464. if ($("body").hasClass('layout-boxed')) { |
@almasaeed2010 Any update on looking into this? This fix seems to solve the issue: https://github.com/almasaeed2010/AdminLTE/pull/799/files |
There a reason why this was closed? Still an issue... |
Please see #1086 |
A temporary solution has been added based on @lanaguanifw's suggestion. It is imperfect in that when the page expands the height of the page will not get fixed. But this issue is lesser of the two evils. We will keep working on finding a solution to solve this problem permanently. Meanwhile, this should suffice. |
What was wrong with this suggestion? https://github.com/almasaeed2010/AdminLTE/pull/799/files This seems to work with window height adjustments after page load. |
I tried the solution before but it didn't work. Have you tried it? |
Yes, it worked fine for me. |
Let me attempt one more time |
Fixed permanently. Thanks @kspearrin and everyone for your patience. |
See example here: http://s.codepen.io/kspearrin/debug/WQrERZ?
Using Firefox or Chrome, make your browser not full screen, then grab your window at the bottom right corner and drag it around a lot to make different sizes. The app.js script crashes the browser as it redraws the page.
Maybe related: #502
The text was updated successfully, but these errors were encountered: