Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .on instead of .click for box actions #304

Closed
wants to merge 1 commit into from

Conversation

soullivaneuh
Copy link
Contributor

This is related to #302.

This will fix issue with ajax loaded html elements and not brake anything.

@almasaeed2010 please feel free to review my PR and comment the code if you have any question.

I don't know how you compile the app.min.js so I didn't touch it for the moment.

Thanks.

@almasaeed2010
Copy link
Contributor

Hello,
I have implemented this in AdminLTE 2.1.0. Since I began working on, accepting PRs is bit more difficult. But you will see the change in the new version. I appreciate your contribution!

@soullivaneuh
Copy link
Contributor Author

@almasaeed2010 Glad to hear it. Where can I see your modifications? Already on git?

@almasaeed2010
Copy link
Contributor

They will be available on Github with the alpha release of v2.1

@soullivaneuh
Copy link
Contributor Author

Hmm just for curiosity, why note commit directly modification for 2.1 on github with the master branch?

And you could keep a 2.0 branch for 2.0.x bugfix version, isn't it?

@almasaeed2010
Copy link
Contributor

I usually push my commits to github when I have an alpha release ready. Many people tend to use the master repo to get their latest updates, which is unfortunate since the master repo is a development space. Nonetheless, we will see the recent changes soon.

Keeping more than one repo would give me too many tasks. As you might know, AdminLTE is just a fun project for me until I finish school. If by then I see more potential in it, I might dedicate more time towards it as necessary. Thanks for understanding.

@soullivaneuh
Copy link
Contributor Author

Ok I understand.

In any case, keeping AdminLTE updated directly on this repo will permit easier contributions! ;)

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants