test(rsbuild-plugin-angular): add file emitter unit tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit bb8a0e6.
☁️ Nx Cloud last updated this comment at |
BioPhoton
commented
Jan 15, 2025
| sourceFile, | ||
| (filename, data) => { | ||
| if (/\.[cm]?js$/.test(filename)) { | ||
| if (isStandardJsFile(filename)) { |
There was a problem hiding this comment.
I extracted the regex for testing and documentation reasons
BioPhoton
commented
Jan 15, 2025
packages/rsbuild-plugin-angular/src/lib/plugin/compilation/file-emitter.unit.test.ts
Outdated
Show resolved
Hide resolved
Coly010
requested changes
Jan 16, 2025
packages/rsbuild-plugin-angular/src/lib/plugin/compilation/build-and-analyze.ts
Outdated
Show resolved
Hide resolved
BioPhoton
force-pushed
the
test/rsbuild-plugin-angular/file-emitter-unit
branch
2 times, most recently
from
fba0073 to
0a6052a
Compare
…readability and testing
Coly010
force-pushed
the
test/rsbuild-plugin-angular/file-emitter-unit
branch
from
7efd6b2 to
65dc64c
Compare
Coly010
approved these changes
Jan 16, 2025
…/build-and-analyze.ts Co-authored-by: Colum Ferry <cferry09@gmail.com>
BioPhoton
force-pushed
the
test/rsbuild-plugin-angular/file-emitter-unit
branch
from
5431119 to
bb8a0e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a spinoff of #53 and only includes it's unit tests.
This PR includes:
isStandardJsFileand renamed file extension helper