fix(rsbuild-plugin-angular): define pluginAngular in root plugins
#77
Conversation
|
View your CI Pipeline Execution ↗ for commit 344b8b3.
☁️ Nx Cloud last updated this comment at |
|
@Coly010 I cannot access Nx Cloud to see the logs, is the project private? |
|
I'm going to need to investigate the changes here more completely. There had been a reason i had the plugins set up in each of the individual configs, but I'm not 100% sure why now. I believe it might have been related to how the instances of the plugins were created, but that might have been an incorrect assumption. As for the playwright e2es, the ssr one should be pointing at 4000, which the port the server is started on and replicates how the user would use the application |
|
@Coly010, can I help you in some ways? |
|
I think the issue comes from the configurations merge in |
| @@ -1,3 +1,4 @@ | |||
| // eslint-disable-next-line @nx/enforce-module-boundaries | |||
There was a problem hiding this comment.
Should we adjust the boundaries instead of disabling it here?
There was a problem hiding this comment.
The boundaries rule is failing due to the usage of a cjs require call somewhere else in the code:
const { createConfig } = require('@ng-rspack/build'); // here
module.exports = () => {
if (global.NX_GRAPH_CREATION !== undefined) {
return createConfig({
browser: './src/main.ts',
server: './src/main.server.ts',
ssrEntry: './src/server.ts',
});
}
return {};
};The rule treats the library as lazy-loaded and throws "cannot directly import a lazy-loaded lib". I don't think we can adjust this behavior but I'm not completely sure. What could be the best approach here? IMO disabling the rule locally since it's used only in 2 places is the way to go.
There was a problem hiding this comment.
I am nor used to work with pnpm. I was just wondering. I have no full overview of the codebase. I was just interested on the thought process as I do the same and always ask my self the same.
| @@ -4,5 +4,5 @@ test('has title', async ({ page }) => { | |||
| await page.goto('/'); | |||
|
|
|||
| // Expect h1 to contain a substring. | |||
| expect(await page.locator('h1').innerText()).toContain('Welcome'); | |||
| expect(await page.locator('h1').textContent()).toContain('Welcome'); | |||
There was a problem hiding this comment.
Could you help me to understand this change please?
There was a problem hiding this comment.
This is probably inherent to the fact that this PR breaks something in SSR, I need to readjust the SSR dev server target and revert this change.
Fixes #75