feat: implement safer hash #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
added a commit
that referenced
this pull request
Jul 12, 2022
Seems that the hash method from #106 is instable: the `.sympy-cache` directory just keeps growing on each run of the uncertainties notebook.
redeboer
added a commit
that referenced
this pull request
Aug 17, 2022
* docs: add tip about `PYTHONHASHSEED` * feat: implement logging hierarchy * feat: warn if using unsafe hash * refactor: move default sympy cache directory to `src`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
With this PR, the hash of a
sympy.Expris generated faster and more safely once you setPYTHONHASHSEEDto a specific value (see sympy/sympy#14835 (comment)). It is set to0by default in Conda'spolarizationenvironment (regenerate it withconda env create --force).The tests assert that the new hash method is indeed unique for different symbol assumptions, but that the speed-up is not as large as anticipated. Hashing the 'folded'$\alpha_x$ expression for the default model:
1.45 s ± 13 mswith unsafe hash1.05 s ± 43 mswithPYTHONHASHSEED=0Other improvements:
logginghierarchy, see feat: implement logging hierarchy tensorwaves#453srcby default in, so that it is more centrally available. (Note that this may cause problems in system-wide installs if admin rights are required.)