Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename fix-first-nbcell to set-nb-cells #49

Merged
merged 9 commits into from
Feb 6, 2022
Merged

refactor: rename fix-first-nbcell to set-nb-cells #49

merged 9 commits into from
Feb 6, 2022

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Feb 6, 2022

Tested this PR ComPWA/ampform#226.

Interface changes

Sub-hook --fix-first-nbcell has been renamed to --set-nb-cell. Use the following example config instead:

  - repo: https://github.com/ComPWA/repo-maintenance
    rev: ...
    hooks:
      - id: set-nb-cells
        args:
          - --add-install-cell
          - --additional-packages=IPython
          - --extras-require=doc,viz

Notebooks can be ignored by adding a Markdown cell with comment <!-- no-set-nb-cells -->.

New features

  • Added an import statement from IPython.display import display. This is to:
  • Config cell and install cell have been switched: install cell comes before the config cell

@redeboer redeboer added ⚠️ Interface Breaking changes to the API ✨ Feature New feature added to the package labels Feb 6, 2022
@redeboer redeboer self-assigned this Feb 6, 2022
redeboer added a commit to ComPWA/ampform that referenced this pull request Feb 6, 2022
sphinx-codeautolink does not detect display function if there is cell
magic in the cell
- Revert "fix: substitute autolink-concat cell"
  This reverts commit 426635c.

- Revert "docs: add IPython.display import as autolink-preface"
  This reverts commit 778fc57.

- Revert "fix: put IPython import in separate cell"
  This reverts commit bc49e11.
@redeboer redeboer merged commit 80d042f into main Feb 6, 2022
@redeboer redeboer deleted the dev branch February 6, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature New feature added to the package ⚠️ Interface Breaking changes to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant